search

brentvatne / stargrave-0

preserving my stars for vanity. former home of react-native-modal
389 stars 65 forks source link

The transparent background doesn't fade in but slide in #52

Closed koppelaar closed 7 years ago

koppelaar commented 8 years ago

If you look at native apps, the transparent background of a modal never slides in, like with this component, but it fades in. The modal itself does slide in.

With this component a black background slides in from the bottom, which feels very broken from a UI point of view.

brentvatne commented 8 years ago

That's a fair point! I don't use this library anymore but if you would like to fix it that would be welcome! It shouldn't be very hard

mschipperheyn commented 8 years ago

Just curious. Do you use another library?

brentvatne commented 8 years ago

@mschipperheyn - I just put a component at the top-level of the app and do position absolute top 0 left 0 bottom 0 right 0 :)