search

brentvollebregt / auto-py-to-exe

Converts .py to .exe using a simple graphical interface
MIT License
3.95k stars 677 forks source link

data include skips empty folders #462

Closed wimmatthijs closed 6 months ago

wimmatthijs commented 7 months ago

Quick Checks

Describe the bug

the "bug" is pretty simple, if you include a data folder, empty folders are omitted. my program goes through a premade structure of folders, that can or cannot be empty. I know it would be best practice to check if folders exist before trying to open any, but on the other hand i would expect data that is added to the project to be added as is, and not omit the empty folders. For me the folder structure, even empty, is my data.

To Reproduce

open a folder in python script, include that folder empty in your additional files

Expected behavior

include empty folders

Your Environment:

github-actions[bot] commented 7 months ago

👋 Hi, just a reminder that if you haven't read the help post yet, give it a read to see if your issue is covered in it and make sure to follow the debugging section.

Also please note, as stated in the README, if your issue is only associated with your application and not auto-py-to-exe itself, please do not create an issue in this repository - instead, comment on the help post, video or create a new discussion.

brentvollebregt commented 7 months ago

I'm not sure myself if PyInstaller supports this - this hints maybe not (but it is quite old)

wimmatthijs commented 7 months ago

Okay, no problem, would have been nice if a fox was possible to avoid some curses in the future.

But two pretty straightforward fixes are possible.

  1. Put dummy placeholder files
  2. Selfcheck the folder structure.

I'll do number two in case somebody mingles with it, it will be fixed every time.

On Thu, Feb 22, 2024, 10:41 AM Brent Vollebregt @.***> wrote:

I'm not sure myself if PyInstaller supports this - this https://github.com/pyinstaller/pyinstaller/issues/4708#issuecomment-596155287 hints maybe not (but it is quite old)

— Reply to this email directly, view it on GitHub https://github.com/brentvollebregt/auto-py-to-exe/issues/462#issuecomment-1959059335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIAQ4UHM4YHET4JTFRGUT3YU4HELAVCNFSM6AAAAABDTCVXQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZGA2TSMZTGU . You are receiving this because you authored the thread.Message ID: @.***>

brentvollebregt commented 7 months ago

Potentially during your build process, you could remove the dummy placeholder files before compressing for distribution

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment on this issue or it will be closed in 5 days.

github-actions[bot] commented 6 months ago

Closing issue due to no activity in more than 60 days.