Lrclib sync content - Githubissues

brentvollebregt / spotify-lyrics-viewer

View the lyrics of the current playing Spotify song in your browser

https://spotify-lyrics-viewer.nitratine.net/

45 stars 8 forks source link

Lrclib sync content #36

Closed lhrolim closed 6 months ago

lhrolim commented 6 months ago

Adding lyric sync progress with lrclib

if lyrics are not found at lrclib genius is used as a fallback. In that case sync is disabled.
Handled scenarios for advancing songs, rewinding and fast forwarding.
Lyrics auto-scroll to position

Other tweaks

ability to pause sync
adjusted debugger settings on vscode to start debugging
added time of track

lhrolim commented 6 months ago

As for removing the geniusURL are you ok with it ? there's no equivalent in lirbrc response as I was double checking:

lhrolim commented 6 months ago

Btw,One of the things I did on my latest code is to change Spotify requests to make it one per second. I realize we could make it more efficiently so that we make an offline progress tracker (on a 1s timeout) and sync with spotify every 5 or 10 seconds progress to account for scenarios of pause and change of songs...

But for my own usage that was frankly quite enough and I couldn't find yet courage/time to make this last adjustment. Do you deem it as worthy vs over engineering ?

lhrolim commented 6 months ago

Nice re-position on the search 🏆 I've left quite a few comments (sorry!) but this is looking great!

When pausing - the current focused text is no longer focused

In terms of the 5s -> 1s, I'm happy with 1s.

no worries! Glad to contribute.

Lemme try working on the pause, it's a good catch.

I must confess I am using it on a daily basis now on the Tesla with the autopilot mode

lhrolim commented 6 months ago

ILRCContent

Thanks! Indeed I have missed some of the comments due to that. Think we will have it closed today!

No worries, always a pleasure to code a bit!

lhrolim commented 6 months ago

GitHub likes to collapse comments when there are a lot and it's not the easiest think to see if you're not used to it - give "Load more..." a click and you'll see some more from yesterday you might not have seen.

I also noticed that when jumping back, the lyrics that I came from (in the future of the song) still display until I catch back up.

Aside from that, it's getting close - I hope you don't mind the back and forth too much 😄

I don't see much of a good way to fix that except for waiting for the next progress loop.

I'd say to keep it as is especially as it's such an edge case. I can only imagine it being worse if u rewind exactly to a guitar solo or something which would take longer for some lyrics progress