brentyi / tyro

CLI interfaces & config objects, from types
https://brentyi.github.io/tyro
MIT License
467 stars 23 forks source link

Consolidate field list generation #118

Closed brentyi closed 7 months ago

brentyi commented 7 months ago

We were previously generating each field list twice:

Here, we consolidate these two passes. This should be both cleaner, faster, and more robust.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b42b485) 99.58% compared to head (17d9936) 99.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== - Coverage 99.58% 99.58% -0.01% ========================================== Files 24 24 Lines 1936 1935 -1 ========================================== - Hits 1928 1927 -1 Misses 8 8 ``` | [Flag](https://app.codecov.io/gh/brentyi/tyro/pull/118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/brentyi/tyro/pull/118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi) | `99.58% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.