brentyi / tyro

CLI interfaces & config objects, from types
https://brentyi.github.io/tyro
MIT License
514 stars 27 forks source link

More error message tweaks #67

Closed brentyi closed 1 year ago

brentyi commented 1 year ago

Based on suggestions in #63.

The main changes are:

Would like to think more about the ramifications of the second and third changes before merging, though they're probably okay!

Some examples:

image image

cc @vwxyzjn

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5498eec) 99.13% compared to head (d3b6791) 99.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #67 +/- ## ======================================= Coverage 99.13% 99.13% ======================================= Files 23 23 Lines 1956 1975 +19 ======================================= + Hits 1939 1958 +19 Misses 17 17 ``` | [Flag](https://app.codecov.io/gh/brentyi/tyro/pull/67/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/brentyi/tyro/pull/67/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi) | `99.13% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/brentyi/tyro/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi) | Coverage Δ | | |---|---|---| | [tyro/\_cli.py](https://app.codecov.io/gh/brentyi/tyro/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi#diff-dHlyby9fY2xpLnB5) | `100.00% <ø> (ø)` | | | [tyro/\_argparse\_formatter.py](https://app.codecov.io/gh/brentyi/tyro/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brent+Yi#diff-dHlyby9fYXJncGFyc2VfZm9ybWF0dGVyLnB5) | `97.23% <100.00%> (+0.20%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vwxyzjn commented 1 year ago

LGTM!