bresc19 / sagrada_familia

A Boarder Game from Cranio Games. Software Engineering Project 2017-2018
0 stars 0 forks source link

box filling logic #2

Closed ingconti closed 6 years ago

ingconti commented 6 years ago

in: sagrada_familia/src/main/java/it/polimi/ingsw/Box.java

you wrote some code. pls explain how you fill it:

bresc19 commented 6 years ago

ok we'll explain it

bresc19 commented 6 years ago

i fix it, and i add a little explanation in every class we've done. i hope it's well-explained. excuse me for the mistake.

ingconti commented 6 years ago

is not clear.

If You write:

private Dice dice;   //dice placed on box. null if it's empty
private boolean full;   //return if there's / not a dice

it means you put a ref to a dice. if so, FULL is the NOT of dice present, so is a useless duplication.

bresc19 commented 6 years ago

yes we're wrong. it's useless. so we'll remove the boolean

ingconti commented 6 years ago

ok, nice. Loking forward for a deep, comprehensive test.

bresc19 commented 6 years ago

ok thanks for all! yes, starting from tomorrow we'll write everything with test!