Test issues - Githubissues

valerio-castelli commented 6 years ago

Good afternoon, There is an issue with your pom.xml configuration that prevents Jenkins from successfully identifying and building your tests. Please follow the "junit 5 maven" guide that you can find on Google to fix the pom and make sure that you are able to run your tests within IntelliJ using a maven build configuration with "test" as goal.

bresc19 commented 6 years ago

good afternoon! sorry for the delay..now it would work!

valerio-castelli commented 6 years ago

We are now correctly seeing your tests. Please be aware though that a significant number of them are failing at the moment! Tests in error: PlayerTest.setAttributes:80 SetSchemasTest.deliverTest:35 » IndexOutOfBounds toIndex = 4 PrivateCardTest.null_score:61 » FileNotFound src/main/data/PrivCard/4.json (No... PrivateCardTest.scoreColour:53 » FileNotFound src/main/data/PrivCard/4.json (N... DeckPrivTest.correctExtract:24 » IndexOutOfBounds Index: 0, Size: 0 DeckPrivTest.correct_extract:31 » IndexOutOfBounds Index: 0, Size: 0 AlesatoreTest.correct_use:80->setupSchema:56 NullPointer AlesatoreTest.wrong_use:94->setupSchema:56 NullPointer DiluenteTest.correct_insertion:87->setupSchema:61 NullPointer DiluenteTest.wrong_insertion:102->setupSchema:61 NullPointer LathekinTest.correct_use:84->setupSchema:60 NullPointer LathekinTest.wrong_use:99->setupSchema:60 NullPointer PennelloEglomiseTest.correct_use:84->setupSchema:58 NullPointer PennelloEglomiseTest.noDice:110->setupSchema:58 NullPointer PennelloEglomiseTest.wrong_use:98->setupSchema:58 NullPointer PennelloPastaSaldaTest.not_pending:97->setupSchema:60 NullPointer PennelloPastaSaldaTest.roll_diceSpace:86->setupSchema:60 NullPointer PennelloPastaSaldaTest.roll_insertion:74->setupSchema:60 NullPointer RigaTest.correct_use:86->setupSchema:61 » NullPointer RigaTest.notSetDice:111->setupSchema:61 » NullPointer RigaTest.wrong_use:99->setupSchema:61 » NullPointer TaglierinaManualeTest.correct_use1:121 NullPointer TaglierinaManualeTest.correct_use2:73 NullPointer TaglierinaManualeTest.wrong_use:98->num_dice:62 NullPointer GameMultiTest.gameInitTest:39 » IndexOutOfBounds Index: 0, Size: 0 SessionTest.join_players:51 » IndexOutOfBounds Index: 0, Size: 0 SessionTest.remove_player:80 » IndexOutOfBounds Index: 0, Size: 0 AdjacentRuleTest.correctInsertion:31 » FileNotFound src/main/data/Schema/24.js... AdjacentRuleTest.wrongInsertion:63 » FileNotFound src/main/data/Schema/24.json... ColourRuleTest.correctInsertion:31 » FileNotFound src/main/data/Schema/24.json... ColourRuleTest.wrongInsertion:45 » FileNotFound src/main/data/Schema/24.json (... EmptyRuleTest.correctInsertion:32 » FileNotFound src/main/data/Schema/24.json ... EmptyRuleTest.wrongInsertion:44 » FileNotFound src/main/data/Schema/24.json (N... NumberRuleTest.correctInsertion:31 » FileNotFound src/main/data/Schema/24.json... NumberRuleTest.wrongInsertion:44 » FileNotFound src/main/data/Schema/24.json (... RulesManagerTest.correctInsertion:32 » FileNotFound src/main/data/Schema/24.js... RulesManagerTest.wrongInsertion:44 » FileNotFound src/main/data/Schema/24.json...

Tests run: 103, Failures: 0, Errors: 37, Skipped: 0

bresc19 commented 6 years ago

We've already discussed with Niccolò about this problem in the last deadline. The problem is that every test on our computer run successfully with intellij and also in maven :

Results :

Tests run: 103, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 5.179 s [INFO] Finished at: 2018-05-25T09:38:35+02:00 [INFO] Final Memory: 11M/224M [INFO] ------------------------------------------------------------------------

We think that the cause (seen your errors) is your wrong import of schemas json file (schemas are imported by SchemaInit(Int n) in Schema class) placed on "src/main/data/schema/24.json". Every test failed infact calls this method. For a strange reason we think that you can't import json from "data" folder (but differently we can). We'll try to move json file in a different path (maybe work). The problem is that we have no way to see if test runs successfully on your machine. If it didn't work we would discuss with you to solve this problem in next lesson . It's very strange we can import them and you can't.

Matteo