search

breser / git2consul

Mirrors the contents of a git repository into Consul KVs.
Other
763 stars 164 forks source link

Add token authentication for webhook (GitLab first) #179

Open fean5959a opened 6 years ago

fean5959a commented 6 years ago

Can you add Token webhook management for security aspect ? I'm not an expert in developpement but you can find my first solution. I only implement GitLab management but other can be added after. I will work soon on GitHub too. For this an extra parameter must be added in hook definition "token" and it must be hashed in SHA 512

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.9%) to 93.292% when pulling 3896b226e9c0a01275b03b181190c6a094a4cfad on fean5959a:master into 2b239b65cddb094c78050420e16054a487a81ac3 on breser:master.