bretonics / CHOMP

Search guide-RNA sequences given a genome or gene sequence
MIT License
4 stars 1 forks source link

Sorting using 'No hits' gets messed up #21

Closed bretonics closed 7 years ago

bretonics commented 7 years ago

After fixing issue #20, the removal of CRISPRs with 'No Hits' results in removing them completely when sorting on line 337.

20 fixes 'undef' issue, but introduces bug where CRISPR may not necessarily be missing in all subject sequences (not only from the singular subject where it is not found). Currently it completely omits those others.

Searching CRISPR targets against subject_1 CRISPR_22 has 0 hits here CRISPR_50 has 0 hits here CRISPR_72 has 0 hits here CRISPR_93 has 0 hits here CRISPR_129 has 0 hits here

Searching CRISPR targets against subject_2 CRISPR_25 has 0 hits here CRISPR_91 has 0 hits here

So instead of omitting CRISPRS 22, 50, 72, 93, 129 only for subject_1, it does it for all subjects.

If 'No Hits' CRISPRs are not removed, sorting fails. Conundrum.