brett19 / rosebrowser

ROSEBrowser is a free and open-source implementation of the ROSE Online 3D MMORPG for web browsers written from scratch using the latest web standards (WebGL, HTML5, Javascript, Threads, ...).
Other
20 stars 17 forks source link

Fix ParticleEffect animations breaking the start position of particles #8

Closed exjam closed 9 years ago

exjam commented 10 years ago

I believe all ZMO animations on particle effects are supposed to be relative and not absolute.

Currently we just use an ObjectAnimator which over writes the position of the particle effect root object, effectively making the animation absolute.

Maybe a fix would be added another layer of THREE.Object3D but that may have consequences on the COORD_TYPE.LOCAL_WORLD this.parent inverse transformations.

https://github.com/brett19/rosebrowser/blob/master/client/js/helpers/effectmanager.js#L245