search

brettcannon / caniusepython3

Can I Use Python 3?
Apache License 2.0
412 stars 60 forks source link

Travis CI: Add Python 3.7 production release and 3.8-dev #184

Closed cclauss closed 6 years ago

cclauss commented 6 years ago

travis-ci/travis-ci#9069

brettcannon commented 6 years ago

I don't think this change is necessary. The Travis docs don't suggest it's needed and I'm already running against Python 3.7 successfully without it. So while I appreciate the PR, I'm not going to accept it. (I'm also purposefully running against 3.6-dev to know early if something needs to be fixed in either this project or Python itself.)

Now if you wanted to submit a PR to test against nightly and made it optional then I would happily accept that change.

cclauss commented 6 years ago

Understood. Thanks for your review.

Just for the record, the Python 3.7 without these changes is 3.7.0a4+ which predates the 3.7.0 production release and also the async is a reserved word change. Similar things with 3.8-dev. This is documented in the Travis issue.

brettcannon commented 6 years ago

Ugh, I wish their docs would say that. 😝

Then can you put it back to 3.6-dev and then I will merge the PR.

cclauss commented 6 years ago

A notice is in the Travis docs https://docs.travis-ci.com/user/languages/python/#development-releases-support