Embed api

[joshkurz]

• adds a new embed api
• decouples graph logic from embed api logic

[brettlangdon]

Test should fail, this file will need to be updated (renamed to embed.js and imports/names fixed): https://github.com/brettlangdon/node-dogapi/blob/e58e06bfa8f4fde1262e87cb4970da5600f28468/test/api/graph.js

[brettlangdon]

other than that, quick glance it looks decent, I won't be able to give it an in-depth look until later tonight or tomorrow morning

[brettlangdon]

lastly... thanks again for your contribution!!!!!! :)

[joshkurz]

still needs tests and things. I have tested this locally and all commands work fine, from command line and from my application.

[brettlangdon]

@joshkurz sorry it took me so long to get around to it, but after my comments, this PR should be good to go.

[joshkurz]

updated and rebased

[brettlangdon]

I had one final thought here, can we link dogapi.graph.createEmbed to dogapi.embed.create, this way we don't have to bump major versions for this release.

e.g.

// graph.js
var embed = require('../embed');

module.exports = {
    createEmbed: embed.create,
    ...
};

Thoughts?

[joshkurz]

yeah that's a good idea.

[joshkurz]

I added the graph.js tests back also.

[brettlangdon]

If you drop the graph createEmbed tests, then lgtm

[joshkurz]

dont you want to make sure its backwards compatible?

[brettlangdon]

Sure, but we shouldn't need to have duplicate tests to ensure that. We could add a test to assert that dogapi.graph.createEmbed exists, but probably not worth having a test just for that.

[joshkurz]

ok well they passed, I honestly just wanted to test to make sure it works at least once to be sure.

[brettlangdon]

:+1: great, one these latest tests pass, I'll merge and release right away!

Thanks your your contribution! I really appreciate the work!