brettminnie / closure-linter

Automatically exported from code.google.com/p/closure-linter
Apache License 2.0
0 stars 0 forks source link

Peformance Regression with 2.3.6 #50

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install 2.3.6
2. git clone --depth 1 git://github.com/mozilla/pdf.js.git pdfjs
3. cd pdfjs
4. time( node make lint)

What is the expected output? What do you see instead?
I expect it to finish in less than a minute, instead it takes over 6 minutes 
and sometimes dies.

What version of the product are you using? On what operating system?
2.3.6 on OSX

Please provide any additional information below.
On version 2.3.5 the command took 36 seconds.

Original issue reported on code.google.com by brendan....@gmail.com on 20 Jul 2012 at 12:54

GoogleCodeExporter commented 9 years ago
Or if you don't have node you can just run:
gjslint --nojsdoc src/*.js web/*.js test/*.js test/unit/*.js 
extensions/firefox/*.js extensions/firefox/components/*.js 
extensions/chrome/*.js

Original comment by brendan....@gmail.com on 20 Jul 2012 at 12:59

GoogleCodeExporter commented 9 years ago
2.3.6 defaults to using multiprocessing. This has caused issues in Windows, and 
I wonder if in some backwards way it is hurting performance on OSX. If you run 
gjslint with the flag --nomultiprocess does it still take as long?

Original comment by a...@google.com on 24 Jul 2012 at 11:05

GoogleCodeExporter commented 9 years ago
Running with above flag did not help, it still hasn't finished and it's been 
over 5 minutes.

 time(gjslint --nojsdoc --nomultiprocess src/*.js web/*.js test/*.js test/unit/*.js extensions/firefox/*.js extensions/firefox/components/*.js extensions/chrome/*.js)

Original comment by brendan....@gmail.com on 25 Jul 2012 at 4:14