brettminnie / closure-linter

Automatically exported from code.google.com/p/closure-linter
Apache License 2.0
0 stars 0 forks source link

--nojsdoc option is broken in 2.3.10 #64

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Even if you set --nojsdoc, closure-linter will still report those errors.

See https://travis-ci.org/mozilla-b2g/gaia/builds/7043293 for one example of 
doc errors being reported.

Original issue reported on code.google.com by rik...@gmail.com on 10 May 2013 at 10:33

GoogleCodeExporter commented 9 years ago
Confirmed
After upgrading my node wrapper[1], my test are broken

Meanwhile this is fixed, you can use the following flag
--disable 220

[1] https://github.com/jmendiara/node-closure-linter-wrapper

Original comment by jmendi...@gmail.com on 15 May 2013 at 2:03

GoogleCodeExporter commented 9 years ago
It seems some parenthesis are missing in errorrules.py

PATCH:
find:
errors.MISSING_JSDOC_TAG_THIS)) and 
          not FLAGS.disable or error not in disabled_error_nums)

replace with:
errors.MISSING_JSDOC_TAG_THIS)) and (
          not FLAGS.disable or error not in disabled_error_nums)) 

Original comment by jmendi...@gmail.com on 15 May 2013 at 2:24

GoogleCodeExporter commented 9 years ago
could we fix this please ?

Original comment by fel...@gmail.com on 21 Jun 2013 at 1:23

GoogleCodeExporter commented 9 years ago
Here's the patch, fixes the problem for me.

Original comment by fel...@gmail.com on 21 Jun 2013 at 1:26

Attachments:

GoogleCodeExporter commented 9 years ago
I'll handle this one.

Original comment by vagra...@google.com on 29 Jul 2013 at 5:38

GoogleCodeExporter commented 9 years ago

Original comment by vagra...@google.com on 29 Jul 2013 at 5:30