search

brettpetch / hosted-scripts

Installers for additional applications not yet integrated into the Swizzin Hosted Platform.
GNU General Public License v3.0
81 stars 17 forks source link

Installerscript for audiobookshelf #15

Open Sh4dowNight opened 9 months ago

Sh4dowNight commented 9 months ago

Installerscript for audiobookshelf

brettpetch commented 9 months ago

Happy with this other than the one change needed. Nice work.

Sh4dowNight commented 9 months ago

Happy with this other than the one change needed. Nice work.

Thank you sir.

What change do you mean in particular?

Maybe it would be useful not to hardcode the version and implement a logic that always installs the latest version.

Besides that feel free to change whatever you desire.

brettpetch commented 9 months ago 
echo 'This is unsupported software. You will not get help with this, please answer `yes` if you understand and wish to proceed'
if [[ -z ${eula} ]]; then
    read -r eula
fi

if ! [[ $eula =~ yes ]]; then
  echo "You did not accept the above. Exiting..."
  exit 1
else
  echo "Proceeding with installation"
fi
Sh4dowNight commented 9 months ago

Done!

brettpetch commented 9 months ago

Going to run this through shellcheck when I get home and ensure that everything is in order, then will squash and merge. Not sure how I feel about binaries existing in $HOME/.config/appname, I think a more appropriate place would be $HOME/.local/bin.

redoXiD commented 9 months ago

I already tested the script on my box, but somehow audiobookshelf does not start. When I run the executable directly, I get this error message: image ~Unfortunately, we were not able to reproduce the error yet~ (tested it on @Sh4dowNight's hbd boxes, hbd boxes of a few other users and a VPS), so further testing would be needed to identify the range of the problem. (it could be a different server configuration as I'm on a different server than the other boxes we tested.) Edit: at least one other server is confirmed to have these problems. However, audiobookshelf versions up to 2.2.23 are working, the problem started with v2.3.0.

I also found a bug report where the same error occured on QNAP NAS devices. In an unpacked working qpkg file (v2.3.3) I discovered that the developer (of the QNAP installer) maybe has solved the problem by copying a node_sqlite3.node file to the installation directory, but I was not able try the fix as as this script runs the binary directly.

brettpetch commented 9 months ago

To me it sounds like sqlite isn't being compiled correctly, maybe a python issue?