brettpoole / growl

Automatically exported from code.google.com/p/growl
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Add Origin-* Headers to GNTP responses #525

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Growl on Windows adds some extra headers in it's responses

GNTP/1.0 -OK NONE
Response-Action: NOTIFY
Origin-Machine-Name: ASUNA
Origin-Software-Name: Growl/Win
Origin-Software-Version: 2.0.9.1
Origin-Platform-Name: Microsoft Windows NT 6.1.7601 Service Pack 1
Origin-Platform-Version: 6.1.7601.65536
X-Message-Daemon: Growl/Win
X-Timestamp: 9/3/2012 4:38:35 PM

It would be useful for OSX Growl to do the same thing. This would help with 
additional information for bug reports.

Original issue reported on code.google.com by kungfudi...@gmail.com on 3 Sep 2012 at 11:41

GoogleCodeExporter commented 8 years ago
Oops, yeah, presently the reply's are pretty bare bones in 2.0, and will 
probably remain that way till 2.1ish.  There are a few other minor spec things 
we don't probably handle entirely properly as well (I believe we aren't 
equipped at this time to deal with app specific headers).  

2.0 was more about getting mainly the structure for the code right more than 
every detail for the spec.  

Original comment by dan...@growl.info on 5 Sep 2012 at 8:37

GoogleCodeExporter commented 8 years ago
Fixed for 2.1, origin headers added back to all response types.  Commit 
[6407d05bb8d4] in Future-2.1

Original comment by dan...@growl.info on 3 Dec 2012 at 3:51