brettpoole / growl

Automatically exported from code.google.com/p/growl
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Power notification description logic. #562

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Have a mac on AC power only
2. Have HardwareGrowler set to show notes on launch
3. Be told that your battery is charging

OR

1. Have a mac with a battery on AC power at 100% charge
2. Have hwgrowler set to show notes on launch (or refire not on battery)
3. Be told that your battery at 100% is charging.

What is the expected output?
If on AC power, and we are told an 

What do you see instead?
Description saying the battery is charging when we aren't in a state that 
supports charging, or we aren't in a charging state.  

Our logic block in determining how long we have to charge when on AC is 
insufficient, and additionally, we should be determining whether we have any 
batteries at all.  

Original issue reported on code.google.com by dan...@growl.info on 25 Nov 2012 at 1:25

GoogleCodeExporter commented 8 years ago
I've tried to improve this, its committed and awaiting review by another 
project member. 

Original comment by dan...@growl.info on 28 Nov 2012 at 1:21

GoogleCodeExporter commented 8 years ago
fixed as of r da27705f5a03

Original comment by rarich...@gmail.com on 1 Dec 2012 at 4:28

GoogleCodeExporter commented 8 years ago

Original comment by ch...@growl.info on 11 Jan 2013 at 6:26