Commands can have several parameters

[vivien]

Hi Brett,

That is the new version of my pull request, to add the ability to have several parameters for commands you add to the bot.

• The first commit is a cleanup, to replace and/or with &&/||, because they are not synonyms. See this article for an explanation. This can avoid subtle bugs :)
• The second commit is the new feature. The trick is done around the line 363. As we've talked about in the last pull request, the only thing to do is to add groups (expression between parenthesis) in the command regex, to allow several parameters in the callback function ("p Hello world!".match(/^p\s+(.*)$/).captures # => ["Hello world!"] shows the idea). By the way, the piece of code to scan the message is a bit cleaner.

Here's an example of command with this feature:

add_command(
  :syntax      => 'rand_in <min> <max>',
  :description => 'Produce a random number between <min> and <max>',
  :regex       => /^rand_in\s+(\d+)\s+(\d+)$/,
  :is_public   => true
) do |sender, params|
  min, max = params.map { |d| d.to_i }
  rand(max - min) + min
end

So that could be used like this: rand_in 30 50 # => 42.

I think it is useful (for a project, I use something like email recipient@somewhere.com Body of the message...), and in my opinion, adding groups to the regex makes the command more readable and easier to handle.

Thanks, Vivien.

[brettstimmerman]

Nice. I think my original plan was to keep message simple, and allow the implementation to parse message in some way if needed. I like how this formalizes the process and is easy to re-use.

I'll hope to have time to roll this by Monday.