Added Support For beginRequest and endRequest (new version)

brettwooldridge / HikariCP

光 HikariCP・A solid, high-performance, JDBC connection pool at last.

Apache License 2.0

19.65k stars 2.9k forks source link

Added Support For beginRequest and endRequest (new version) #2126

Open fmeheust opened 8 months ago

fmeheust commented 8 months ago

Continued work from pull request https://github.com/brettwooldridge/HikariCP/pull/2079. Addressed review comments https://github.com/brettwooldridge/HikariCP/pull/2079#discussion_r1367934838 and added tests.

fmeheust commented 8 months ago

Given that this is a Java 11+ version of HikariCP and that request boundaries (Connection.beginRequest() and Connection.endRequest()) are present since Java 9, I have removed the check for JDBC version. I have added a property that allows to explicitly enable request boundaries. Calls to Connection.beginRequest() and Connection.endRequest() have been moved to HikariPool.getConnection and HikariPool.recycle respectively.

fmeheust commented 8 months ago

@lfbayer Can you please review my latest changes to this pull request ?

jeandelavarene commented 5 months ago

@lfbayer could you please review this request? Thank you!

krismohan commented 2 months ago

Hi @lfbayer any update on the merge? Thanks!