search

brettwooldridge / HikariCP

光 HikariCP・A solid, high-performance, JDBC connection pool at last.
Apache License 2.0
19.91k stars 2.92k forks source link

Changed the log level of `final void logPoolState(String... prefix)` from `debug` to `info`. #2139

Closed 1chz closed 10 months ago

1chz commented 11 months ago

The housekeeper's record of the current status of total, active, idle and waiting connections in the DBCP is highly useful when operating a product targeting real users. However, to view this log, specific log level settings need to be configured, and the relevant information is being shared. Our company also conducts this setup separately to reference the related logs.

What do you think about changing this log level from debug to info?

Please refer to this Stack Overflow question and answer for more details.

https://stackoverflow.com/questions/60757590/logging-hikaricp-spring-boot

logging.level.com.zaxxer.hikari.HikariConfig=DEBUG 
logging.level.com.zaxxer.hikari=TRACE
lfbayer commented 10 months ago

If you are really interested in monitoring pool state it would be better to use one of the metrics trackers (ie: dropwizard, micrometer, or prometheus).

I think that a large percentage of users would complain if this were suddenly logged at info. The only time you really need this information in the logs specifically is if there is a problem with your application and the way it is configured.

I will not be merging this change.