brettwooldridge / HikariCP

光 HikariCP・A solid, high-performance, JDBC connection pool at last.
Apache License 2.0
19.91k stars 2.92k forks source link

Duplicate connection in try with resources clause removed (Fixes #2152) #2155

Closed bjorndarri closed 8 months ago

bjorndarri commented 10 months ago

Fixes #2152

Duplicate connection in try with resources clause caused close() being called twice on each connection.

lfbayer commented 9 months ago

Can you add a unit test for this change?

I actually don't know what the duplicate connection is in there. It looks oddly intentional, but removing it seems like a good idea.

quaff commented 9 months ago

It's an obvious typo fix, It's safe enough if it doesn't fail other tests.