The logging logic in PoolEntryCreator seems to be incorrectly logging "Connection not added, " if the loggingPrefix value is null - even if the connection was added.
I've created a minimalist PR that I think fixes the issue. However, based on other references to loggingPrefix in conditional statements in PoolEntryCreator.call(), it seems like the intent is not to log if loggingPrefix is null... but in the case of a connection not being added, a logging prefix is hardcoded to "Connection not added, "... so I'm not clear on the intent :) Perhaps it needs a more thorough reworking/clarification of the logic?
The logging logic in
PoolEntryCreatorseems to be incorrectly logging "Connection not added, " if theloggingPrefixvalue isnull- even if the connection was added.The
poolEntryCreatorvariable inHikariPoolis instantiated without aloggingPrefix, so this execution path always run, even if a connection was addedI've created a minimalist PR that I think fixes the issue. However, based on other references to
loggingPrefixin conditional statements inPoolEntryCreator.call(), it seems like the intent is not to log ifloggingPrefixis null... but in the case of a connection not being added, a logging prefix is hardcoded to "Connection not added, "... so I'm not clear on the intent :) Perhaps it needs a more thorough reworking/clarification of the logic?