search

brettwooldridge / HikariCP

光 HikariCP・A solid, high-performance, JDBC connection pool at last.
Apache License 2.0
19.91k stars 2.92k forks source link

Try-with-Resources Not Closing Database Connections for One Select Query #2213

Open baliyanshilpa04 opened 3 months ago

baliyanshilpa04 commented 3 months ago

Facing an issue with try-with-resources as it is not closing the database connections automatically particularly for one select query while working for other queries of the same class within a java application. Please suggest what could be the issue here. Steps to Reproduce Execute the problematic select query using the try-with-resources statement. Monitor the database connections to observe that the connection is not closed. Execute other queries in the same class to confirm that their connections are closed properly. Expected Behavior The database connection should be automatically closed after the try-with-resources block for all queries.

Actual Behavior The database connection remains open for one specific select query, causing potential resource leaks.

baliyanshilpa04 commented 2 months ago

Any comments please??

IRus commented 1 month ago

@baliyanshilpa04 why do you think connection should be closed? Please provide a configuration and test that reproduces described behavior

PavlovIvan commented 3 weeks ago

@baliyanshilpa04 HikariCP reuses connections. When you call the method close you will return the connection to the pool, but the physical connection to the database will still exist. Look at com.zaxxer.hikari.pool.ProxyConnection for more details.