brettwooldridge / NuProcess

Low-overhead, non-blocking I/O, external Process implementation for Java
Apache License 2.0
710 stars 84 forks source link

Clear userWantsWrite before calling onStdinReady. (#112) #113

Closed bturner closed 4 years ago

bturner commented 4 years ago

Prior to this change, if wantWrite() was called from another thread while NuProcess was calling onStdinReady(ByteBuffer), that request would be "lost" if onStdinReady returned false. Depending on where input is coming from (for example a Servlet 3.1 ReadListener), that could result in the process getting "stuck" indefinitely.

bturner commented 4 years ago

Thanks for the quick merge and release, @brettwooldridge. I appreciate all your support.

brettwooldridge commented 4 years ago

@bturner No, thank you for the contributions.