search

brettwooldridge / NuProcess

Low-overhead, non-blocking I/O, external Process implementation for Java
Apache License 2.0
710 stars 84 forks source link

Add Automatic-Module-Name manifest entry to make NuProcess module-system-friendly #142

Closed timboudreau closed 1 year ago

timboudreau commented 1 year ago

A trivial PR that simply adds a manifest entry for Automatic-Module-Name which makes it possible to use this library from modular Java libraries and get a result that is safe to publish on Maven central.

bturner commented 1 year ago

I made a small whitespace tweak to keep the POM consistent, but other than that, looks good to me. Thanks for the contribution @timboudreau.

jonathanl-telenav commented 1 year ago

Thanks for NuProcess.

bturner commented 1 year ago

Credit to @brettwooldridge for that; I'm just trying to help with the maintenance.

I'll need to refresh my memory on how to do the release process for this; it's been a minute since I released 2.0.3 (which I'm realizing I forgot to push the tag for)

timboudreau commented 1 year ago

Is there a general plan for when there might be a release that incorporates this change?

Happy to contribute any effort that would be helpful. The current snapshot version is working well for us, and I would like to release our branch that migrates our maven plugin to use NuProcess to run its external processes, but we need a modular release on Maven central to link against.

bturner commented 1 year ago

I'll try to get 2.0.4 out this week

timboudreau commented 1 year ago

That's awesome! Thank you!

bturner commented 1 year ago

2.0.4 has been released. It may take a little while to be fully published on Central.