search

brettwooldridge / NuProcess

Low-overhead, non-blocking I/O, external Process implementation for Java
Apache License 2.0
712 stars 84 forks source link

Windows environment variables #62

Closed ilya-klyuchnikov closed 8 years ago

ilya-klyuchnikov commented 8 years ago

fixes #60 Tests: https://ci.appveyor.com/project/ilya-klyuchnikov/nuprocess/build/13 (before fix) https://ci.appveyor.com/project/ilya-klyuchnikov/nuprocess/build/14 (after fix)

ilya-klyuchnikov commented 8 years ago

Thanks, for merging. However, I have one more addition - https://github.com/ilya-klyuchnikov/NuProcess/commit/b8f2f9fc78e82731271c28780935899e2b7a2880. The last commit is about handling case sensitivity in the same way as Java does in java.lang.ProcessEnvironment on Windows (Mac and Linux versions are different). The point is that when merging System.environ() with a user provided environment Java compares names up to case sensitivity.

And the last commit passes CI - https://ci.appveyor.com/project/ilya-klyuchnikov/nuprocess/build/25, while the previous don't (https://ci.appveyor.com/project/ilya-klyuchnikov/nuprocess/build/22).

bturner commented 5 years ago

I've opened pull request #103 to apply the changes @ilya-klyuchnikov suggested after this was merged, to fix the build on Windows.