search

brettwooldridge / NuProcess

Low-overhead, non-blocking I/O, external Process implementation for Java
Apache License 2.0
718 stars 84 forks source link

Expose exitCode on NuProcess #69

Closed cdancy closed 7 years ago

cdancy commented 7 years ago

Can we expose exitCode on the NuProcess interface? If there is no reason why we can't I can submit a PR for this change.

cdancy commented 7 years ago

@brettwooldridge any thoughts?

brettwooldridge commented 7 years ago

@cdancy Any reason you can't use the NuProcessHandler.onExit(int exitCode) callback, or the value returned by NuProcess.waitFor()?

cdancy commented 7 years ago

@brettwooldridge that works as well ;) I was looking at your README.md and assumed you had all the callback methods exposed there.