Use ALIGN_NONE only on x86-64.

brettwooldridge / NuProcess

Low-overhead, non-blocking I/O, external Process implementation for Java

Apache License 2.0

712 stars 84 forks source link

Use ALIGN_NONE only on x86-64. #93

Closed bturner closed 6 years ago

bturner commented 6 years ago

Added EpollEvent.EpollEventPrototype.detectAlignment(), which uses the "os.arch" JVM property to detect x86-64 and set ALIGN_NONE
- On any other architecture, ALIGN_GNUC is used
- When running a 32-bit JVM on a 64-bit OS, ALIGN_GNUC will be used
Updated EpollEventTest.testSize to set the expected size to 12 or 16 bytes depending on the architecture and/or pointer size

bturner commented 6 years ago

@brettwooldridge This is the line I'm thinking along.

One thing I was a bit concerned about was running 32-bit Java on a 64-bit OS, but I think it should work correctly. If the JVM is a 32-bit process, it will use one of the 32-bit libjnidispatch libraries.

A different approach might be to use JNA's Platform to make choices. Since it has a fair amount of normalization built on experience; I've opened pull request #94 for that approach.

bturner commented 6 years ago

Declining in favor of #94, which has already been merged.