brettz9 / jump-to-anchor

Jump to the closest anchor for a selected element
MIT License
9 stars 2 forks source link

For GitHub: consider jump to comment without the -permalink tail #11

Closed grahamperrin closed 5 years ago

grahamperrin commented 5 years ago

With #5 as a random example, with version 0.9.0 of the extension, a jump from the space to the right of the date of the comment before closure leads to:

– which initially includes a view of the tail of the preceding comment (call it an offset, if you like).

Compare with this, without the -permalink tail, focusing on the required comment:

Enhancement request

Please: is it possible, reasonable, to make an exception for jumps to GitHub comments?

Side notes

The initial offset that occurs (in Waterfox and in Firefox) can be worked around by a reload. A bug in Mozilla code, I guess.

grahamperrin@momh167-gjp4-8570p:~ % pkg query '%o %v %R' firefox waterfox
www/firefox 64.0_3,1 FreeBSD
www/waterfox 56.2.6 poudriere
grahamperrin@momh167-gjp4-8570p:~ % date ; uname -v
Wed  2 Jan 2019 08:09:34 GMT
FreeBSD 13.0-CURRENT r342466 GENERIC-NODEBUG 
grahamperrin@momh167-gjp4-8570p:~ % 

Display #Anchors can help to discover required anchors.

grahamperrin commented 5 years ago

# test

grahamperrin commented 5 years ago

Sorry, scrub this issue.

I just realised, the offset also occurs when using an anchor without the -permalink tail:

image