Closed grahamperrin closed 5 years ago
With #5 as a random example, with version 0.9.0 of the extension, a jump from the space to the right of the date of the comment before closure leads to:
https://github.com/brettz9/jump-to-anchor/issues/5#issuecomment-157824444-permalink
– which initially includes a view of the tail of the preceding comment (call it an offset, if you like).
Compare with this, without the -permalink tail, focusing on the required comment:
-permalink
Please: is it possible, reasonable, to make an exception for jumps to GitHub comments?
The initial offset that occurs (in Waterfox and in Firefox) can be worked around by a reload. A bug in Mozilla code, I guess.
grahamperrin@momh167-gjp4-8570p:~ % pkg query '%o %v %R' firefox waterfox www/firefox 64.0_3,1 FreeBSD www/waterfox 56.2.6 poudriere grahamperrin@momh167-gjp4-8570p:~ % date ; uname -v Wed 2 Jan 2019 08:09:34 GMT FreeBSD 13.0-CURRENT r342466 GENERIC-NODEBUG grahamperrin@momh167-gjp4-8570p:~ %
Display #Anchors can help to discover required anchors.
# test
…
Sorry, scrub this issue.
I just realised, the offset also occurs when using an anchor without the -permalink tail:
With #5 as a random example, with version 0.9.0 of the extension, a jump from the space to the right of the date of the comment before closure leads to:
https://github.com/brettz9/jump-to-anchor/issues/5#issuecomment-157824444-permalink
– which initially includes a view of the tail of the preceding comment (call it an offset, if you like).
Compare with this, without the
-permalink
tail, focusing on the required comment:Enhancement request
Please: is it possible, reasonable, to make an exception for jumps to GitHub comments?
Side notes
The initial offset that occurs (in Waterfox and in Firefox) can be worked around by a reload. A bug in Mozilla code, I guess.
Display #Anchors can help to discover required anchors.