search

breuerfelix / chromedriver-py

chromedriver self updated binaries for all platforms
https://pypi.org/project/chromedriver-py/
Apache License 2.0
52 stars 15 forks source link

Exception: Couldn't find a binary for your system: Darwin / arm64 #13

Closed lundstrj closed 2 years ago

lundstrj commented 2 years ago

Exception: Couldn't find a binary for your system: Darwin / arm64. Please create an Issue on github.com/breuerfelix/chromedriver-py and include this Message.

This was attempted on a MBA M1 with Python 3.9.4 (I am helping a coworker setup my tool on this machine). The system is clearly Darwin and the machine is "arm64" so I'd assume that path simply isn't a file. As to why that is, I do not know.

I noticed you simplified the logic regarding M1 somewhat recently, could that have caused a regression?

I myself am on an identical machine and I do not have this issue (but I know my coworker has also setup Python 2.7 on his box (due to reasons)) so it isn't as bog standard as my own setup.

I'd be happy to help debug this, I just don't know what would be of use to us.

lundstrj commented 2 years ago

I tried downgrading to older versions of chromedriver-py and 95.0.4638.17 works OK, anything newer does not.

breuerfelix commented 2 years ago

thanks for the issue! i identified the problem... the m1 binary is not included in the package since i forgot to put it in the manifests file... the bad part: i can't fix already uploaded versions so you will need to wait for a new chromedriver version to come out :/

breuerfelix commented 2 years ago

@lundstrj in this version the m1 isnt included aswell but since it is the old code it will use the x64 binary and runs this one through rosetta which might be a little slower. this is a workaround but once the new version is out it will perform faster on arm :)

lundstrj commented 2 years ago

You made quick work of this, well done. Thank you for being so responsive and also for authoring this tool.

breuerfelix commented 2 years ago

de nada :) thanks for those detailed issues, it makes fixing things way easier!

mandrigin commented 2 years ago

it looks like it failed to deploy to pypi

File already exists. See https://pypi.org/help/#file-name-reuse for more information.

we are also very much looking forward to this fix, we just got an M1 mac for a new team member

breuerfelix commented 2 years ago

the problem is: i can't publish the same version twice ... lets see if i can publish a new version manually which won't match with the chrome version

breuerfelix commented 2 years ago

@lundstrj @mandrigin can you test version 97.0.4692.37 ?

lundstrj commented 2 years ago

Sure thing. I'll give it a go.