search

breuerfelix / chromedriver-py

chromedriver self updated binaries for all platforms
https://pypi.org/project/chromedriver-py/
Apache License 2.0
52 stars 15 forks source link

Follow up question to #26 #31

Closed MichaelWerner closed 1 year ago

MichaelWerner commented 1 year ago

Hello,

great that it works with cx_freeze. I like pyinstaller because it creates a single executable. Do you have any plans to fix this problem?

thanks,

Michael

breuerfelix commented 1 year ago

Hey, do you have some example repo that i can reproduce and see the errors? Maybe with some Readme so i can follow the instructions? I never used pyinstaller now cx_freeze myself. It would be best to know your use case.

That way i can investigate if this is actually fixable or if pyinstaller just won't let you bundle other binaries :)

MichaelWerner commented 1 year ago

Hi Felix,

I do. However, I did some work at the weekend and haven't pushed it yet. I will do that tonight and let you know. One thing I did was to install the new version of selenium and with that, chromedriver. Before that change, the exe that pyinstaller created worked. Now, it doesn't. I updated pyinstaller on my machine, too.

Thanks,

Michael

MichaelWerner commented 1 year ago

Hi Felix,

here is the script. https://github.com/MichaelWerner/Python/blob/master/scrape_nfl.py

I built the exe doing this pyinstaller --onefile scrape_nfl.py

When I run the exe, it fails with the error #26

python scrape_nfl.py works

Thanks,

Michael

breuerfelix commented 1 year ago

Hey Michael, I am sorry to say but bundling this into one binary is not possible, because it would need to bundle the chromedriver binary INTO the python binary. And what is the path to the Chromedriver binary then? It would be somehow merged into the program binary. So for the chromedriver there is nothing that it could start. This is also the reason why programs install into a Folder and have multiple files (lets say, one reason, not the only reason)

So yeah, bundling this package into a single executable won't ever work, sadly. I will close this Issue but just comment on it if you have more questions regarding this topic :)