Minor fixes to the TextField and Select components - Githubissues

brewkit / components

An easy-to-theme design system for creating impactful UIs using React and TypeScript.

MIT License

5 stars 5 forks source link

Minor fixes to the TextField and Select components #92

Closed FDrazicC4 closed 4 years ago

FDrazicC4 commented 4 years ago

Description

This pull request consists of 2 commits:

TextField: Currently, error icon's container is always present, occupying fixed amount of space at the end of the input. This is especially visible in case of type='number', where up and down arrows are always moved to the left. This commit fixes the issue by displaying error icon's container only if hasError property is set to true.
Select: Use isDisabled property to disable the component, as other components do.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.