search

brewlabs / sendpress

SendPress: Email Newsletter Manager for WordPress
61 stars 24 forks source link

CSS to inline styles #39

Open mattsnowboard opened 11 years ago

mattsnowboard commented 11 years ago

class-css-to-inline-styles.php It looks like this isn't used in the code. Is there a reason why? Does it work? I'd like to implement something like this to fix a few problems with custom templates. For example my designer wants the templates to have all links bold. And since the links are added outside the template design I can't inline the bold style. The only style that gets applied right now is the color.

If the CSS to inline styles doesn't work, would you be open to adding a filter so I could take the final HTML email (including the unsubscribe link and everything) and process it? I can add the code, but I only want to do it if you'd support it in an upcoming release. I don't want SendPress updates to break my client's site.

joshlyford commented 11 years ago

The code does work but is not currently used because it requires some changes to the template for it to run correctly. It currently removes any inline styles that are set but we are working a on fix for this. We can certainly add a filter for you to support what you need.

mattsnowboard commented 11 years ago

I've created a PR with a filter. It would be nice to have the inline CSS code work (so I don't need to define a function to add inline styles myself and I can keep the design all in one place), but this works for my needs.