brewlabs / sendpress

SendPress: Email Newsletter Manager for WordPress
61 stars 24 forks source link

Permissions and visible tabs #94

Open bhwebworks opened 9 years ago

bhwebworks commented 9 years ago

I have a client site where I'm the admin and my client has an editor role. I've set the SendPress Permissions so that this client has the following permissions enabled:

What this client does not have access to is Settings and Add-ons.

I'm guessing this would be typical settings for most sites that have admin and Editor/Author/etc. roles in use.

What I've noticed is that with these settings an Editor can still see and click on the Settings, Help, and Pro tabs. When they click on the Settings or Pro tabs they get the following message:

Sorry. You dont have the ability to view this page.

Besides the typo in that message, (don't), I personally don't think they should even see the tabs or be able to click on them. There is no reason I can think of for them to know these tabs exist and wonder why they can't access them.

When they click on the Help tab, they see everything there, and have access to information about the site and/or server that someone with their role doesn't need to know at all.

So I'm suggesting the following:

  1. Tabs are hidden from user roles with no access to those tabs.
  2. The Help tab is added to the Permissions options, or better yet is available only to administrators.
bhwebworks commented 9 years ago

As a follow-up to this, I just noticed that when an Editor has permission to view the Queue(s), which I think they should if they're able to send emails, there are messages there with links to the Settings tab, and if the Editor doesn't have permission to view the Settings tab, those messages should probably not be visible either.

Specifically:

On Queues: Active and Queues: Stuck the following message is there:

You can adjust these settings here: Settings > Sending Account.

On Queues: Send History the message reads:

You can adjust these settings here: Settings > Advanced.