search

brewsci / homebrew-num

:beer::1234: Homebrew formulae for numerical methods
BSD 2-Clause "Simplified" License
11 stars 12 forks source link

Switch to GitHub Actions #56

Closed SeekingMeaning closed 3 years ago

SeekingMeaning commented 4 years ago

Based on homebrew-bio

Requires a new develop branch that should be set as the default branch instead of master. The default branch can be changed in Settings → Branches: https://github.com/brewsci/homebrew-num/settings/branches

sjackman commented 4 years ago

I'm not sure which exact scopes should be enabled, but I enabled repo, admin:repo_hook, and workflow for my personal tap (@sjackman could you verify this?)

Only public_repo is needed. I'd suggest keeping the permissions as slim as possible. You can add more permissions later as needed, even without needing to recreate the token.

sjackman commented 4 years ago

I believe that we could configure the Brewsci organization to use the same HOMEBREW_GITHUB_API_TOKEN and HOMEBREW_BINTRAY_KEY configuration and token for all of its repos. I haven't yet looked into this GitHub feature.

SeekingMeaning commented 4 years ago

I believe that we could configure the Brewsci organization to use the same HOMEBREW_GITHUB_API_TOKEN and HOMEBREW_BINTRAY_KEY configuration and token for all of its repos.

Yeah I'm fairly certain that'll work. Do happen to have the HOMEBREW_GITHUB_API_TOKEN stored somewhere? You can't access existing tokens at https://github.com/settings/tokens

dpo commented 3 years ago

Hm. I can't seem to access settings for this repo any more, and so can't set develop as the default branch.

@sjackman Any ideas?

@SeekingMeaning is this PR still up to date? Sorry it took so long to get to it.

SeekingMeaning commented 3 years ago

@SeekingMeaning is this PR still up to date? Sorry it took so long to get to it.

I'm leaning towards not having the develop branch as Homebrew doesn't clone the master branch by default anymore and instead clones whichever branch is set as the default on GitHub

dpo commented 3 years ago

Thank you!

SeekingMeaning commented 3 years ago

Wait I wasn't finished

dpo commented 3 years ago

Oops. Sorry.

dpo commented 3 years ago

Should I revert or do you want to open a new PR?