brewsci / homebrew-num

:beer::1234: Homebrew formulae for numerical methods
BSD 2-Clause "Simplified" License
11 stars 12 forks source link

Update brewsci-r.rb #78

Open Gasman2014 opened 3 years ago

Gasman2014 commented 3 years ago

Unable to install brewsci-mumps due to error in associated package, brewsci-r.

I think this pr should fix it but I seem to be going round in circles. I have installed other formulae from this repo (eg Tetgen) but Brew insists on going back to tap the original brewsci/num repo and then failing on brewsci-r - which is a package I don't even want to install from here (I have it already).

$brew tap
gasman2014/num
homebrew/cask
homebrew/core

$brew install gasman2014/num/brewsci-mumps
==> Installing brewsci-mumps from gasman2014/num
==> Tapping brewsci/num                                          <------------- WHY?????
Cloning into '/usr/local/Homebrew/Library/Taps/brewsci/homebrew-num'...
remote: Enumerating objects: 69, done.
remote: Counting objects: 100% (69/69), done.
remote: Compressing objects: 100% (49/49), done.
remote: Total 470 (delta 43), reused 34 (delta 20), pack-reused 401
Receiving objects: 100% (470/470), 98.92 KiB | 1.87 MiB/s, done.
Resolving deltas: 100% (215/215), done.
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/brewsci/homebrew-num/Formula/brewsci-r.rb
brewsci-r: Calling depends_on :java is disabled! Use "depends_on "openjdk@11", "depends_on "openjdk@8" or "depends_on "openjdk" instead.
Please report this issue to the brewsci/num tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/brewsci/homebrew-num/Formula/brewsci-r.rb:25
dpo commented 3 years ago

What's gasman2014/num? Is it a fork of this repo? If so, I think brew insists on tapping this repo because formulae tell it to, e.g., https://github.com/brewsci/homebrew-num/blob/master/Formula/brewsci-mumps.rb#L24.

One build error is

/usr/local/Homebrew/Library/Taps/brewsci/homebrew-num/Formula/brewsci-r.rb:25:3: C: [Correctable] dependency "openjdk@8" (line 25) should be put before dependency "xz" (line 24)

The other seems to be occurring during the R configure step:

checking whether bzip2 support suffices... configure: error: bzip2 library and headers are required

I can't look into this right now but I'll be happy to review a PR.

You may be able to fix things temporarily in your local tap by changing occurrences of brewsci/num in the formulae to gasman2014/num.