search

brewsci / homebrew-science

:snowflake: Scientific formulae for Homebrew and Linuxbrew (legacy)
https://github.com/brewsci
Other
154 stars 76 forks source link

remove anvio #230

Closed ozcan closed 5 years ago

ozcan commented 5 years ago

Hi, This formula installs a really old version and not maintained. Can we remove it?

dpo commented 5 years ago

This tap isn't maintained. We normally remove a formula from here when an updated version is available elsewhere.

@sjackman Would anvio be appropriate for brewsci/homebrew-bio?

ozcan commented 5 years ago

Thanks for the reply @dpo. I was maintaining this formula for a long time, but we started using conda instead as our userbase demanded it. This formula has many (20+) pypi dependencies and we do release somewhat frequently. Keeping all the pypi links and hashes updated requires some manual work, so I found conda better suits for our use case, just listing pypi dependencies. So I think removal will be better as nobody will maintain it.

sjackman commented 5 years ago

Hi, Özcan. I've created a new formula for anvio here: https://github.com/brewsci/homebrew-bio/pull/559/files You'll see that it should be a lot easier to maintain than the previous one.

It works fine locally, but on CircleCI and Azure I'm getting this odd error:

==> pip3 install --prefix=/home/linuxbrew/.linuxbrew/Cellar/anvio/5.3/libexec .
Processing /tmp/anvio-20190219-19644-vchggv/anvio-5.3
Files/directories not found in /tmp/pip-req-build-qah_lkc6/pip-egg-info

I'm not quite sure what the error means or what's causing it. I'll troubleshoot it later this week.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

sjackman commented 5 years ago

Merged. Thanks for the PR, Özcan.