search

brewsci / homebrew-science

:snowflake: Scientific formulae for Homebrew and Linuxbrew (legacy)
https://github.com/brewsci
Other
154 stars 76 forks source link

Change depends_on: java to depends_on: "openjdk@8" #267

Closed npklein closed 3 years ago

npklein commented 3 years ago

Trying to install a formula gives errors because depends_on: java is disabled. Can be fixed by replacing java with openjdk@8. I tested with https://github.com/npklein/homebrew-science, if I do brew install brewsci/homebrew-science/plink2 I get Error: Cannot tap brewsci/science: invalid syntax in tap!, if I do brew install npklein/homebrew-science/plink2 it installs correctly.

I can make a pull request if necesarry.

olafx commented 3 years ago

Same issue. Am trying to install GDL. This fixed at least the issue of the entire tap not working.

mvieth commented 3 years ago

I see the message: Calling depends_on :java is disabled! Use "depends_on "openjdk@11", "depends_on "openjdk@8" or "depends_on "openjdk" instead. So maybe just openjdk (without explicit version) would be more portable? I think it would be great if you would open a pull request, @npklein

sjackman commented 3 years ago

I've merged PR https://github.com/brewsci/homebrew-bio/pull/1255 to migrate plink2 from Brewsci/science, which is not maintained, to Brewsci/bio.