brexhq / substation

Substation is a toolkit for routing, normalizing, and enriching security event and audit logs.
https://substation.readme.io
MIT License
322 stars 16 forks source link

fix(metrics): AWS CloudWatch Embedded Metrics Dimensions #179

Closed jshlbrd closed 3 months ago

jshlbrd commented 3 months ago

Description

Motivation and Context

This fixes a bug that causes multiple attributes to be incorrectly assigned to dimensions in the metric (discovered while testing https://github.com/brexhq/substation/pull/178 in a production pipeline). The fix has these dimensions:

"Dimensions":[["FunctionName","FreshnessType"]]

The incorrect dimensions are:

"Dimensions":[["FunctionName"],["FreshnessType"]]

This bug doesn't impact the metric value, but it does affect filters in CloudWatch (and may affect downstream systems).

How Has This Been Tested?

Types of changes

Checklist: