brexis / laravel-workflow

Use the Symfony Workflow component in Laravel
MIT License
281 stars 104 forks source link

Service Provider's mergeConfigFrom() always mix in the "straight" demo workflow #40

Closed cirdog closed 5 years ago

cirdog commented 5 years ago

https://github.com/brexis/laravel-workflow/blob/89358dcabf6b23f1e9d4493210fd35d5063d13e8/src/WorkflowServiceProvider.php#L37

In my opinion the mergeConfigFrom() is not necessary because the config publishing already provides a demo workflow for users to get started. Moreover, merging it in Service Provider actually contaminates the user's workflow config by adding a demo entry ("straight") every time while actually nobody needs it.

Please remove the mergeConfigFrom() from the Service Provider, thanks very much!