search

brezerk / q4wine

Q4Wine is a Qt GUI for W.I.N.E. It will help you manage wine prefixes and installed applications.
http://q4wine.brezblock.org.ua/
GNU General Public License v3.0
208 stars 40 forks source link

Improve mount #1

Closed ghost closed 13 years ago

ghost commented 13 years ago

The commits create new symlinks when mounting $WINEPREFIX/dosdevices/${DRIVE}: pointing to the mountpoint and $WINEPREFIX/dosdevices/${DRIVE}:: pointing to the Image file (not the double colon). Apparently this is needed so that the images are recognised as a proper cd/dvd drive. This also adds on column to the database which determines which wine drive to use for the mounted images (configurable in the GUI)

brezerk commented 13 years ago

Wow.

Thank you :) I need some time to examine and test your code.

ghost commented 13 years ago

You may not want to add 19a9a83 (it is not related to my addition), but for me running losetup with sudo didn't work properly so I removed it since the gained functionality was nice but not neccessary for me. I noticed this method was being called way too often, though. Since it spawns a new process every time this should be reduced.

brezerk commented 13 years ago

I test mount improvements and seems it works fine. Good job! I'l gladly include your code to my source tree. Thanks :)

btw: If you wish, you can send to me information which can be placed in q4wine's about dialog.

Well, I'l revert 19a9a83 changes. I knew it is a horrible dirty hack, but I can't find any other way to get information from loop device. I plan to add cdemu (http://cdemu.org) support and use it as default mount backend.