brezerk / q4wine

Q4Wine is a Qt GUI for W.I.N.E. It will help you manage wine prefixes and installed applications.
http://q4wine.brezblock.org.ua/
GNU General Public License v3.0
207 stars 40 forks source link

Links imported from Windows desktop do not work #103

Closed ktamp closed 7 years ago

ktamp commented 7 years ago

E.g. installing game Syberia from GOG creates a desktop link which is imported by Q4Wine. Trying to open this link causes error -1.

The actual command issued by Q4Wine to run Syberia is:

/usr/bin/env WINEPREFIX='/home/ktamp/.wine' WINESERVER='/usr/bin/wineserver' WINELOADER='/usr/bin/wine' WINEDLLPATH='/usr/lib32/wine/' WINEARCH='win32' WINEDEBUG='-all' /bin/sh -c "cd '/home/ktamp/.wine/dosdevices/c:/GOG Games/Syberia/' && '/usr/bin/wine' 'C:\windows\command\start.exe Unix homektamp.winedosdevicesc:usersPublicDesktopSyberia.lnk' 2>&1 "

The culprit here is in the last part: 'C:\windows\command\start.exe Unix homektamp.winedosdevicesc:usersPublicDesktopSyberia.lnk'

If this is split in two and the second part is simplified (while adding missing backslashes), it works: 'C:\windows\command\start.exe' 'c:\users\Public\Desktop\Syberia.lnk'

brezerk commented 7 years ago

hi @ktamp

there should be Syberia.desktop file located at /home/ktamp/.wine/dosdevices/c:/users/ktamp/Desktop can you send me it please?

brezerk commented 7 years ago

Ok.

Good news: I was able to reproduce this with the other game downloaded from GOG. Bad news: now I have to walk through this game before I will create a fix for this issue... >_<

brezerk commented 7 years ago

This issue was caused by odd regexp parser: the '/unix /home...' should be passed as arguments to start.exe.

This commit: https://github.com/brezerk/q4wine/commit/82de0db7716f8717f7f57991bdfb15c0e983548a should fix the issue. Note you will need to remove imported icons in the import folder manually before testing the fix.

ktamp commented 7 years ago

I confirm it is working now. Thank you for this quick fix!

brezerk commented 7 years ago

ur'welcome. thanks for bug report.