brezerk / q4wine

Q4Wine is a Qt GUI for W.I.N.E. It will help you manage wine prefixes and installed applications.
http://q4wine.brezblock.org.ua/
GNU General Public License v3.0
207 stars 40 forks source link

Build failure on Qt 5.11 due to qt5_use_modules removal #125

Closed prettyv closed 6 years ago

prettyv commented 6 years ago

Since Qt 5.11 q4wine fails to build with Unknown CMake command "qt5_use_modules" because this macro has been removed. Qt's CMake Macro Reference says about qt5_use_modules: This macro is obsolete. Use target_link_libraries with IMPORTED targets instead

According to this using target_link_libraries and prepending Qt5:: to the module names should generally be enough, although my CMake knowledge is limited.

VFedyk commented 6 years ago

This issue directly relates to compilation bug during installation of packages q4wine and q4wine-git from AUR in Archlinux.

There is the meaningful part of the output in the terminal:

==> Starting build()...
-- The C compiler identification is GNU 8.1.0
-- The CXX compiler identification is GNU 8.1.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done

 * Utility for Wine applications and prefixes management.
 * Copyright (C) 2008-2018 by Oleksii S. Malakhov <brezerk@gmail.com>
 * http://brezblock.org.ua/

-- Q4Wine build environment -- 

-- Fount Qt Core version ; 5.11.0
-- Build realm is   : Linux x86_64

-- Q4Wine build options --

-- Version                       : 1.3.7
-- CMAKE_INSTALL_PREFIX          : /usr
-- DESKTOP_ENTRY_PATH            : /usr/share/applications
-- PIXMAPS_ENTRY_PATH            : /usr/share/icons/hicolor
-- PIXMAPS_UNITY_ENTRY_PATH      : /usr/share/icons/ubuntu-mono-dark
-- MANPAGE_ENTRY_PATH            : /usr/share/man
-- LIBS_ENTRY_PATH               : /usr/lib

-- DEBUG                         : OFF
-- RELEASE                       : ON
-- QT5                           : ON
-- WITH_ICOUTILS                 : ON
-- WITH_SYSTEM_SINGLEAPP         : ON
-- WITH_WINEAPPDB                : ON
-- USE_BZIP2                     : OFF
-- USE_GZIP                      : OFF
-- WITH_DBUS                     : ON

-- LINGUAS                       : af;cs;de;en;es;fa;he;it;ja;pl;pt_BR;ru;uk;zh_TW;zh_CN;fr

-- See INSTALL file for details and more info --

-- Searching for fuseiso binary --

--     fuseiso : /usr/bin/fuseiso

-- Searching for icoutils binaries (WITH_ICOUTILS=ON) --

--     wrestool : /usr/bin/wrestool
--     icotool  : /usr/bin/icotool

-- Searching for QtSingleApplication package (WITH_SYSTEM_SINGLEAPP=ON) --

--      library : /usr/lib/libQt5Solutions_SingleApplication-head.so
--  include dir : /usr/include

CMake Error at src/q4wine-lib/CMakeLists.txt:88 (qt5_use_modules):
  Unknown CMake command "qt5_use_modules".

-- Configuring incomplete, errors occurred!
See also "/tmp/yaourt-tmp-vf/aur-q4wine-git/src/build/CMakeFiles/CMakeOutput.log".
tehnick commented 6 years ago

909bc7ffa7a2f704d669315c262ef39db1ef25b1