Closed jedrzejowski closed 2 years ago
hi @jedrzejowski
Thanks a lot for PR. I'll review it today.
Thanks!
Looks good. Thanks a lot! 👍
You broke support of Ubuntu Focal and older: https://launchpad.net/~tehnick/+archive/ubuntu/q4wine-devel/+packages As well as all systems with Qt < 5.15. Is it worth it?
error: ‘endl’ is not a member of ‘Qt’
Yeah, not that good. Thank you for a note.
пн, 10 янв. 2022 г., 01:31 Boris Pek @.***>:
You broke support of Ubuntu Focal and older: https://launchpad.net/~tehnick/+archive/ubuntu/q4wine-devel/+packages As well as all systems wit Qt < 5.15. Is it worth it?
— Reply to this email directly, view it on GitHub https://github.com/brezerk/q4wine/pull/189#issuecomment-1008446661, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF2DA2ETN3SPVNWZZYT2TUVILGPANCNFSM5H5YJ7TA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you modified the open/close state.Message ID: @.***>
Just reminding that build for Ubuntu Focal still not fixed yet. Example of build log is here. Example of error:
/<<BUILDDIR>>/q4wine-devel-1.3.13+2+g9735939/src/q4wine-lib/q4wine-lib.cpp: In member function ‘void corelib::getBuildFlags()’:
/<<BUILDDIR>>/q4wine-devel-1.3.13+2+g9735939/src/q4wine-lib/q4wine-lib.cpp:574:53: error: ‘endl’ is not a member of ‘Qt’
574 | Qcout<<QObject::tr("Buildtime flags are:")<<Qt::endl<<Qt::endl;
Ubuntu Focal (20.04 LTS) uses Qt 5.12.8.
I have re-checked: even Ubuntu Bionic (18.04 LTS) was supported until this PR. https://launchpad.net/~tehnick/+archive/ubuntu/q4wine/+packages https://launchpad.net/~tehnick/+archive/ubuntu/q4wine-devel/+packages
I have made following changes:
endl
->Qt::endl
left
->Qt::left
This will remove almost every warning from compiler.