brezerk / q4wine

Q4Wine is a Qt GUI for W.I.N.E. It will help you manage wine prefixes and installed applications.
http://q4wine.brezblock.org.ua/
GNU General Public License v3.0
208 stars 40 forks source link

Konsole: Workaround for bug #15 no longer needed #87

Closed nairaner closed 7 years ago

nairaner commented 8 years ago

Behavior when using argument -e is fixed, which caused workaround to stop working and using the default command now works

brezerk commented 8 years ago

Thank you for reporting. Will take a look on it at the evening.

brezerk commented 8 years ago

Hi @nairaner

Are you talking about gnom-terminal app, is it correct? Can you provide me correct arguments example please?

nairaner commented 8 years ago

I'm talking about konsole. After some update i couldnt start debug and notice that issue and used konsola1 to start it correctly.

brezerk commented 8 years ago

hm.......

@nairaner what version are you using?

[ himera ] brezerk@pts/3:3  ~ $
> 09/21/16 19:43:05 EEST > konsole -v    
Qt: 5.6.1
KDE Frameworks: 5.25.0
Konsole: 16.04.3

and it still require -e command to execute cmd

  -e <cmd>                  Command to execute. This option will catch all following arguments, so use it as the last option.
nairaner commented 8 years ago

I use konsole 16.08 I mean commit 865ded03bbf7aff9e84d7788f8497a1120089da1 I linked konsole1 to konsole and now this works for me

/usr/bin/konsole1 --noclose -e " /usr/bin/env  WINEPREFIX='/home/nairaner/.wine'  WINESERVER='/usr/bin/wineserver'  WINELOADER='/usr/bin/wine'  WINEARCH='Default'  WINEDEBUG='-all'  WINEDLLOVERRIDES=''  LANG=''  /bin/sh -c \"cd '/home/nairaner' && /usr/bin/nice -n 10 /usr/bin/wine  explorer.exe /desktop=winecfg,800x600  'winecfg' -h 2>&1 \" "

And this doesnt

/usr/bin/konsole --noclose -e /bin/sh -c  " /usr/bin/env  WINEPREFIX='/home/nairaner/.wine'  WINESERVER='/usr/bin/wineserver'  WINELOADER='/usr/bin/wine'  WINEARCH='Default'  WINEDEBUG='-all'  WINEDLLOVERRIDES=''  LANG=''  /bin/sh -c \"cd '/home/nairaner' && /usr/bin/nice -n 10 /usr/bin/wine  explorer.exe /desktop=winecfg,800x600  'winecfg' -h 2>&1 \" "
brezerk commented 8 years ago

Reproduced with 16.08.1 Working on workaround now.

brezerk commented 8 years ago

hm.... @nairaner if I am getting it correctly, this is konsole bug.

  -e <cmd>                   Command to execute. This option will catch all
                             following arguments, so use it as the last option.

So it says: This option will catch all following arguments however, it actually does not follow expected behavior:

[ himera ] brezerk@pts/0:9  ~ $
> 09/24/16 23:59:06 EEST > konsole -v                      
konsole 16.08.1
[ himera ] brezerk@pts/0:10  ~ $
> 09/24/16 23:59:54 EEST > konsole -e /bin/sh -c 'echo lol'
Unknown option 'c'.
[ himera ] brezerk@pts/0:11 :( 1 ~ $
> 09/24/16 23:59:56 EEST > /bin/sh -c 'echo lol'           
lol
[ himera ] brezerk@pts/0:12  ~ $
brezerk commented 8 years ago

https://bugs.kde.org/show_bug.cgi?id=369297

brezerk commented 8 years ago

oh. yeah: https://bugs.kde.org/show_bug.cgi?id=366793

nairaner commented 8 years ago

But is there a point using

/usr/bin/konsole --noclose -e /bin/sh -c  $command

instead of just

/usr/bin/konsole --noclose -e $command

which works on newer version of konsole and was introduced as a workaround for a ?bug? in 2012? Both work correctly in

Qt: 5.7.0
KDE Frameworks: 5.26.0
Konsole: 16.04.3

and latter works also in 16.08.1

brezerk commented 8 years ago

sigh

I believe there was a reason of adding this -e /bin/sh -c ugly logic.

yeah. here your are: https://github.com/brezerk/q4wine/issues/15#issuecomment-10964079

so just

/usr/bin/konsole --noclose -e $command

does not work as expected in the 4.10 Konsole :( So reverting this workaround will cause problems for KDE 4.x users. (I can't confirm that is was fixed in 4.10+ unfortunately)

That's the tricky part: I am not sure how to keep both KDE4 and KDE5 working without 366793 being fixed on KDE side =\

Gfurst commented 7 years ago

Is there any working for this atm?

brezerk commented 7 years ago

hi @Gfurst afik this has been fixed by KDE team: https://bugs.kde.org/show_bug.cgi?id=366793 (not sure when it will be released).

As a temporary workaround: you may wish to use xterm instead of konsole.

brezerk commented 7 years ago

this bug seems to be fixed by KDE team. So I am going to close this one. Any objections?

nairaner commented 7 years ago

I dont see a reason not to

brezerk commented 7 years ago

ty. closing.