brezerk / q4wine

Q4Wine is a Qt GUI for W.I.N.E. It will help you manage wine prefixes and installed applications.
http://q4wine.brezblock.org.ua/
GNU General Public License v3.0
208 stars 40 forks source link

Console launch environment uses dead setting fields #90

Closed RomanHargrave closed 8 years ago

RomanHargrave commented 8 years ago

When launching a console within a prefix, q4wine sets several variables that are useful for scripts, etc, which need to know information about what version of wine is needed for a session.

q4wine attempts to add some of those, but ultimately fails as the routine which launches the terminal does not use what I assume is the new version management system and instead expects specific setting fields to be populated.

sh_args << "env";
sh_args << QString("WINEPREFIX=%1").arg(prefix_info.value("path"));
if (!prefix_info.value("libs").isEmpty())
    sh_args << QString("WINEDLLPATH=%1").arg(prefix_info.value("libs"));
sh_args << QString("WINELOADER=%1").arg(prefix_info.value("loader"));
sh_args << QString("WINESERVER=%1").arg(prefix_info.value("server"));
if (!prefix_info.value("arch").isEmpty())
    sh_args << QString("WINEARCH=%1").arg(prefix_info.value("arch"));
brezerk commented 8 years ago

Hi @RomanHargrave which one wine version are you using?

From what I see this settings are still actual for 1.9.21 also they are listed in the official wiki https://www.winehq.org/docs/wine

brezerk commented 8 years ago

Oh. Never mind i got your message now :)

This commit should fix the issue https://github.com/brezerk/q4wine/commit/2db0bb08fe46fb334ff528e2d3c1939ef4dd7bce

Thanks a lot for reporting. Reopen if needed.