brgmnn / fish-docker-compose

Fish shell completions for docker-compose
MIT License
74 stars 10 forks source link

Allow path completions #16

Open max-sixty opened 6 years ago

max-sixty commented 6 years ago

Describe the problem

If I type

docker-compose run test mylibrary/<tab>

...where test is a service and mylibrary is a path (relative to the current path), I don't get any completions for the path. Without fish-docker-compose, I do get completions.

While in some compose configurations it's correct to disallow that, in the (I think fairly common?) case that the current path is mapped as a volume into the container, it's valid.

And my prior is that it's better to allow too much than disallow too much

How would you feel about deferring to the existing completions in the case that fish-docker-compose doesn't a valid completion?

Software versions

Fish Shell version: fish, version 2.7.1 Docker Compose version: docker-compose version 1.18.0, build 8dd22a9 Compose file version: 2.2