Change reference to this.resolveBricks

brh55 / react-native-masonry

:raised_hands: A pure JS react-native component to render a masonry~ish layout for images with support for dynamic columns, progressive image loading, device rotation, on-press handlers, and headers/captions.

MIT License

1.32k stars 157 forks source link

Change reference to this.resolveBricks #18

Closed brh55 closed 7 years ago

brh55 commented 7 years ago

Fixes issue #17 , will probably need to add additional logic to remove older bricks as this is appending to the current datasource. This also includes a bump to the package version as a minor fix (0.1.1).

Verification Steps:

Update props.bricks later with a different data set (easiest to go with [] -> resolve a promise -> [bricks])
The bricks should be rendered

ghost commented 7 years ago

Your pull request doesn't follow our guidelines. Please fix the following:

Pull request description must include verification steps (?)

Click here for details.

Thank you! :pray: _{This comment was made by GitMagic – Magically enforcing your contribution guidelines.}

ghost commented 7 years ago

Thank you, the title and description now looks good! :bowtie: