Added spacing prop to set Column gutterSize

brh55 / react-native-masonry

:raised_hands: A pure JS react-native component to render a masonry~ish layout for images with support for dynamic columns, progressive image loading, device rotation, on-press handlers, and headers/captions.

MIT License

1.32k stars 157 forks source link

Added spacing prop to set Column gutterSize #60

Closed lautarocelerative closed 7 years ago

lautarocelerative commented 7 years ago

Adjustment of the gutter size of the columns

Issue: https://github.com/brh55/react-native-masonry/issues/8

ghost commented 7 years ago

Your pull request doesn't follow our guidelines. Please fix the following:

Pull request description cannot be empty (?)

Click here for details.

Thank you! :pray: _{This comment was made by GitMagic – Magically enforcing your contribution guidelines.}

ghost commented 7 years ago

Thank you, the title and description now looks good! :bowtie:

brh55 commented 7 years ago

@lautarocelerative

Looks great so far, but could you add a few things before a merge.

Update readme props table to include spacing props (http://www.tablesgenerator.com/markdown_tables, you should be able to copy and paste table in here), you may need to indicate that the spacing is a multiplier of 1% of the available view.
Add a PropTypes definition to warn against non-number types

lautarocelerative commented 7 years ago

@brh55 Done!

brh55 commented 7 years ago

Splendid! 👯‍♂️ Merge, thanks for the contribution!