brh55 / react-native-masonry

:raised_hands: A pure JS react-native component to render a masonry~ish layout for images with support for dynamic columns, progressive image loading, device rotation, on-press handlers, and headers/captions.

MIT License

1.32k stars 157 forks source link

ERROR: "Object" is read-only #92

Closed ghost closed 6 years ago

ghost commented 6 years ago

https://github.com/brh55/react-native-masonry/blob/6e61c038ae9acd17e348e6022ecfa816ed5715ee/components/Masonry.js#L154

Having a trouble in playing with library. Checking the codebase, bricks should be defined aslet. Please check asap and update the repo. Regards.

brh55 commented 6 years ago

@projavascripter You're right that would appear to cause issues, oddly it didn't on my end. But feel free to send a PR for finding this! 👍

mckmarc commented 6 years ago

I had the same problem, it would be nice to have it updated....

thanks

jayeshanandani commented 6 years ago

I can replicate same issue at my end. Changing that to let works.

jayeshanandani commented 6 years ago

98 PR already exists for this.

brh55 commented 6 years ago

👍 merged, thanks for catching that.

irenemmassy commented 3 years ago

Changing that to var or let it works.